Conversation
add <main>, single <h1>, lang='en' (placeholder until i18n), DOCTYPE to stop chrome 'quirk mode' warning in console With these Axe gives no issues, at least prior to loading files. i18n should be able to follow the previewers model using i18n.js, etc. Note the locale param is dvLocale. Also need a blank placeholder logo for when a site doesn't have one. Possibly could use site name in title as well?
Member
Author
|
Merging now that 5.14 is out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QDR work to improve accessibility and add support for using the fixity/checksum algorithm specified by the Dataverse instance (using an API call to be added in 5.14 - defaults to MD5 (as before) on earlier Dataverse versions).
Also adds a Site Logo (if configured in Dataverse - as for previewers).
Closes #12
Partially fixes #11