Bump dependencies / ESM / bundle with esbuild#36
Conversation
|
Tests seem to be failing with |
|
Thanks for approving CI. I had a hard time with the test suite since there's not a binary for M1/ARM chips. |
Which binary? Both server and CLI have native m1 and linux aarch64 builds (though possibly not ancient releases that might be referred to in the tests, so try using a more recent server/CLI version there). |
https://github.com/edgedb/setup-edgedb/blob/main/src/main.ts#L230 |
|
Oh, feel free to add |
|
@elprans I think I've fixed the problems. Trigger CI for me? |
|
Thanks, will continue |
98941c6 to
3d3e761
Compare
|
Everything looks good here. Ready for review/merge when able 😄 |
elprans
left a comment
There was a problem hiding this comment.
LGTM! Thanks for working on this!
esbuildinstead of@vercel/nccNever even heard of ncc until this, not really sure their purpose.
esbuildis definitely one of the new standards.@actions/corewarningsset-outputis deprecated #34)Though the build is still CJS, as that's what
@actions/coreemits for now.Some work went into mocking ESM modules for Jest, but I believe the result is a nicer experience anyways.
Fixes #34
I really tried to limit any logical changes here, since this is so large in other ways.
I would like to refactor further in later PRs if allowed.