[ADO-2034] Add gemiusIdSystem#12
Open
mmuras-gemius wants to merge 4 commits into
Open
Conversation
pgrzegorczyk-gemius
approved these changes
Jul 29, 2025
| primaryScriptWindow.gemius_cmd('get_ruid', function (ruid, desc) { | ||
| if (desc.status === 'ok') { | ||
| setResult({id: ruid}); | ||
| } else if (desc.status === 'no-consent') { |
There was a problem hiding this comment.
A to w końcu jak to jest z tą zgodą? Bo to by sugerowało, że ta jakaś nasza biblioteka mówi czy jest zgoda czy nie
There was a problem hiding this comment.
Dopisałem komentarz w https://gemius.atlassian.net/browse/HIT-1201?focusedCommentId=124834
Może faktycznie rozwiązaniem jest żeby to wydawcy sami przekazywali do skryptu gemius.js informacje, że potrzeba sprawdzać dodatkowe zgody. Wtedy po stronie Prebid.js wystarczy tak jak jest.
pgrzegorczyk-gemius
approved these changes
Jul 31, 2025
| clock.tick(6400); | ||
| }); | ||
|
|
||
| it('should return null id if no consent', function () { |
There was a problem hiding this comment.
Tak jak rozmawialiśmy - fajnie byłoby dodać jeszcze jakiś test na przypadek jak zgoda jest
pgrzegorczyk-gemius
force-pushed
the
master
branch
from
cd88331 to
7ca73fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information