Refactor Gemstone iOS library build#1130
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the iOS build process by replacing manual framework assembly with an XcodeGen-based workflow. Key changes include the addition of a build-ios-lib.sh script for building the Rust static library, a new project.yml for project generation, and simplified justfile tasks. Review feedback highlighted a potential case-sensitivity bug when copying generated headers and suggested removing a redundant PATH export in the XcodeGen configuration.
0xh3rman
force-pushed
the
gemstone-ios-lib
branch
2 times, most recently
from
5ac251f to
fe875d7
Compare
0xh3rman
force-pushed
the
gemstone-ios-lib
branch
3 times, most recently
from
37d82bb to
62b2415
Compare
0xh3rman
force-pushed
the
gemstone-ios-lib
branch
from
62b2415 to
f0d1a1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
just build-iosjust test-ios