fix: port standalone dev/test fixes from the redesign branch - #73
Merged
ajbozarth merged 2 commits intoJul 30, 2026
Merged
Conversation
Two independent fixes made on the redesign branch that apply cleanly to main, pulled over as the redesign is on indefinite hold: - next.config.mjs: replace the hardcoded LAN IP in allowedDevOrigins (committed from on-device testing) with a NEXT_DEV_ORIGIN env var, so contributors point it at their own machine or leave it empty without editing the config. - playwright.config.ts: add retries (2 in CI, 1 locally) so hydration races and cold-compile timeouts don't red an otherwise-passing suite; this also makes the existing trace: 'on-first-retry' actually capture a trace. Ported from the redesign branch (generative-computing#67). Assisted-by: Claude Code Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
Contributor
Author
|
I set to auto-merge once this gets an approval since its a minor test/dev fix |
planetf1
reviewed
Jul 28, 2026
Assisted-by: Claude Code Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
planetf1
approved these changes
Jul 30, 2026
planetf1
left a comment
planetf1
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix — is exactly right.
planetf1
approved these changes
Jul 30, 2026
planetf1
left a comment
planetf1
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix — retries: process.env.CI ? 2 : 0 is exactly right.
Merged
via the queue into
generative-computing:main
with commit Jul 30, 2026
5af8070
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent fixes that were made on the redesign branch (#67) but apply cleanly to
mainon their own. Pulling them over as standalone changes since the redesign is on indefinite hold.Changes
next.config.mjs— replace the hardcoded LAN IP inallowedDevOrigins(committed from on-device testing) with aNEXT_DEV_ORIGINenv var. Contributors can point it at their own machine's LAN IP, or leave it unset, without editing the config.playwright.config.ts— addretries(2 in CI, 1 locally) so hydration races and cold-compile timeouts don't red an otherwise-passing e2e suite. This also makes the existingtrace: 'on-first-retry'actually capture a trace.Notes
Ported from the redesign branch (#67). No behavior change on the site itself — both are dev/CI ergonomics.