Skip to content

docs: update docs/examples/tools/README.md#1328

Merged
akihikokuroda merged 3 commits into
generative-computing:mainfrom
akihikokuroda:toolreadme
Jun 24, 2026
Merged

docs: update docs/examples/tools/README.md#1328
akihikokuroda merged 3 commits into
generative-computing:mainfrom
akihikokuroda:toolreadme

Conversation

@akihikokuroda

@akihikokuroda akihikokuroda commented Jun 23, 2026

Copy link
Copy Markdown
Member

Pull Request

Issue

Fix #1327

Description

update examples/tools/README.md

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code was added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Attribution

  • AI coding assistants used

Adding a new component, requirement, sampling strategy, or tool?

If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.

  • Component
  • Requirement
  • Sampling Strategy
  • Tool

NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.

@akihikokuroda
akihikokuroda requested a review from a team as a code owner June 23, 2026 22:35
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jun 23, 2026
@planetf1

Copy link
Copy Markdown
Contributor

Hi @akihikokuroda — heads up on a terminology overlap. PR #1322 (currently in draft) sweeps docs/examples/tools/README.md as part of the #1279 terminology sweep, changing "HuggingFace's smolagents library" → "Hugging Face's smolagents library" and "HuggingFace ecosystem" → "Hugging Face ecosystem".

Your diff restores the old "HuggingFace" spelling in those lines. Whichever of the two PRs merges second will overwrite the other's changes on those two lines.

When you rebase, could you pick up the "Hugging Face" spelling from the post-merge upstream? Happy to coordinate on ordering if that's easier.

@akihikokuroda

Copy link
Copy Markdown
Member Author

@planetf1 This PR doesn't change any lines that has "Hugging". So it should be OK.

Comment thread docs/examples/tools/README.md Outdated
## Related Documentation

- See `mellea/stdlib/tools/interpreter.py` for interpreter implementation
- See `mellea/stdlib/tools/python_tool.py` for python_tool implementation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- See `mellea/stdlib/tools/python_tool.py` for python_tool implementation
- See `mellea/stdlib/tools/interpreter.py` for python_tool implementation

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it.

Comment thread docs/examples/tools/README.md Outdated
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Comment thread docs/examples/tools/README.md Outdated
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>

@AngeloDanducci AngeloDanducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akihikokuroda
akihikokuroda added this pull request to the merge queue Jun 24, 2026
Merged via the queue into generative-computing:main with commit e71aac0 Jun 24, 2026
9 checks passed
@akihikokuroda
akihikokuroda deleted the toolreadme branch June 24, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Fix tool calling examples README for Docusaurus compliance and API updates

4 participants