Skip to content

fix: change tool_calls from dict to list#1435

Draft
akihikokuroda wants to merge 5 commits into
generative-computing:mainfrom
akihikokuroda:issue1431
Draft

fix: change tool_calls from dict to list#1435
akihikokuroda wants to merge 5 commits into
generative-computing:mainfrom
akihikokuroda:issue1431

Conversation

@akihikokuroda

@akihikokuroda akihikokuroda commented Jul 23, 2026

Copy link
Copy Markdown
Member

Pull Request

Issue

Fixes #1431

Description

This changed tool_calls from dict to list instead of set because of the follow reason

Aspect Dict Set List
Parallel same-name calls ❌ Collapses ✓ Preserved ✓ Preserved
Execution order ✓ Preserved ❌ Lost ✓ Preserved
Duplicate handling Overwrites silently Deduplicates silently Must validate explicitly
Component prefixing ✓ Works ❌ Order lost ✓ Works
Requires __hash__/__eq__ No Yes No
Equality semantics N/A Unclear N/A
Observability ✓ Simple ❌ Hidden deduplication ✓ Visible duplicates
Implementation effort N/A Medium (add hash/eq) Low (validate helper)

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code was added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Attribution

  • AI coding assistants used

Adding a new component, requirement, sampling strategy, or tool?

If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.

  • Component
  • Requirement
  • Sampling Strategy
  • Tool

NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.

Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda akihikokuroda changed the title change tool_calls from dict to list fix: change tool_calls from dict to list Jul 23, 2026
@github-actions github-actions Bot added the bug Something isn't working label Jul 23, 2026
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda

Copy link
Copy Markdown
Member Author

This has broader changes than expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate same-name parallel tool calls collapse to a single execution

1 participant