chore: update pyproject authors and add CITATION.cff - #589
Conversation
- Replace individual authors with Mellea Contributors team - Add CITATION.cff with founding authors for academic citation Closes generative-computing#584 Part of generative-computing#453 Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
|
Currently this removes the author list from pyproject.toml and creates a CITATION.cff but I am unsure if the authors list in pyproject.toml was actually correct, so I had Bob run an analysis comparing the authors list to the actual git commit authors and the CODEOWNERS. Based on this analysis we should decide if we want to add/remove anyone from the CITATION.cff before merge See Bob's analysis below: Comprehensive Contributor Analysis for CITATION.cffThree Lists ComparedList 1: CITATION.cff (Current - 9 authors, ordered as in pyproject.toml)
List 2: Git Commit Authors (43+ total, ordered by first commit)
Additional 31+ contributors: Alex Bozarth (✓ CODEOWNERS), Paul Schweigert (✓ CODEOWNERS), Nigel Jones (✓ CODEOWNERS), Fred Reiss, James Busche, Juan Cruz-Benito, Akihiko Kuroda (✓ CODEOWNERS), Alex Jenkins, Alexander Skula, Angelo Danducci (✓ CODEOWNERS), Avihu Dekel, BJ Hargrave, Bobby, Keerthi Ram, Keshav Ramji, Lucian Popa, Mariela Lanza, Mateus Devino, Prasanna Sattigeri, Serjik, Tulio Coppola, Yousef El-Kurdi, github-actions[bot], and more... List 3: CODEOWNERS Team (@generative-computing/mellea-contributors - 10 members)
Special reviewers for Cross-Reference Analysis✓ In ALL three lists (5):
✓ In CITATION.cff but NOT in CODEOWNERS team (4):
✓ In CODEOWNERS team but NOT in CITATION.cff (5):
✓ Have git commits but in NEITHER list (33+):
Key Insights1. CODEOWNERS team is MORE current than CITATION.cff
2. Early contributors were overlooked
3. CITATION.cff has 2 non-code contributors
Discussion Questions for PR1. Should CITATION.cff align with CODEOWNERS team?Add these 5 CODEOWNERS members to CITATION.cff:
FOR: Recognizes current active contributors, aligns with who actually maintains the project 2. Should we add early contributors who committed before some CITATION.cff authors?Add these early contributors:
FOR: Recognizes early code contributions, more fair 3. Should we remove authors without git commits?Remove:
FOR: Clear criteria (must have commits), aligns with CODEOWNERS approach 4. What about Elron Bandel and Xiaojie Guo?They're in CITATION.cff but NOT in CODEOWNERS team:
Should they be added to CODEOWNERS team? Options Summary
My Recommendation: Option C (Merge both lists)Rationale:
Proposed CITATION.cff (14 authors, alphabetical by last name):
Alternative: Keep as-is (Option A) if the team prefers CITATION.cff to remain a historical record of founding team only. |
Based on PR review feedback, removing CITATION.cff as GitHub's built-in citation feature is sufficient and avoids the complexity of determining original authors. Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
…uting#589) * chore: update pyproject authors and add CITATION.cff - Replace individual authors with Mellea Contributors team - Add CITATION.cff with founding authors for academic citation Closes generative-computing#584 Part of generative-computing#453 Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com> * chore: remove CITATION.cff file Based on PR review feedback, removing CITATION.cff as GitHub's built-in citation feature is sufficient and avoids the complexity of determining original authors. Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com> --------- Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
Misc PR
Type of PR
Description
Updates author metadata following modern open source conventions as discussed in #453.
Changes:
pyproject.tomlwith "Mellea Contributors" teamCITATION.cffwith founding authors for academic citationCloses #584
Closes #453
Testing