Skip to content

chore: update pyproject authors and add CITATION.cff - #589

Merged
ajbozarth merged 2 commits into
generative-computing:mainfrom
ajbozarth:chore/update-authors-584
Mar 6, 2026
Merged

chore: update pyproject authors and add CITATION.cff#589
ajbozarth merged 2 commits into
generative-computing:mainfrom
ajbozarth:chore/update-authors-584

Conversation

@ajbozarth

@ajbozarth ajbozarth commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Updates author metadata following modern open source conventions as discussed in #453.

Changes:

  • Replace individual authors in pyproject.toml with "Mellea Contributors" team
  • Add CITATION.cff with founding authors for academic citation
  • Enables GitHub's "Cite this repository" feature

Closes #584
Closes #453

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

- Replace individual authors with Mellea Contributors team
- Add CITATION.cff with founding authors for academic citation

Closes generative-computing#584
Part of generative-computing#453

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
@ajbozarth ajbozarth self-assigned this Mar 5, 2026
@ajbozarth
ajbozarth requested a review from a team as a code owner March 5, 2026 23:48
@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@mergify

mergify Bot commented Mar 5, 2026

Copy link
Copy Markdown

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@ajbozarth

Copy link
Copy Markdown
Contributor Author

Currently this removes the author list from pyproject.toml and creates a CITATION.cff but I am unsure if the authors list in pyproject.toml was actually correct, so I had Bob run an analysis comparing the authors list to the actual git commit authors and the CODEOWNERS.

Based on this analysis we should decide if we want to add/remove anyone from the CITATION.cff before merge

See Bob's analysis below:

Comprehensive Contributor Analysis for CITATION.cff

Three Lists Compared

List 1: CITATION.cff (Current - 9 authors, ordered as in pyproject.toml)

  1. Nathan Fulton (nathan@ibm.com)
  2. Hendrik Strobelt (hendrik.strobelt@ibm.com)
  3. Avinash Balakrishnan (avinash.bala@us.ibm.com)
  4. Elron Bandel (elron.bandel@ibm.com)
  5. Masataro Asai (masataro.asai@ibm.com)
  6. Supriya Lall (supriya.lall@partner.ibm.com)
  7. Xiaojie Guo (xiaojie.guo@ibm.com)
  8. Jake LoRocco (jake.lorocco@ibm.com)
  9. Ja Young Lee (Ja.Young.Lee@ibm.com)

List 2: Git Commit Authors (43+ total, ordered by first commit)

  1. Nathan Fulton - 2025-07-31 ✓ CITATION ✓ CODEOWNERS
  2. Avinash Balakrishnan - 2025-07-31 ✓ CITATION ✓ CODEOWNERS
  3. JJ Asghar - 2025-08-01 ✗ CITATION ✗ CODEOWNERS
  4. Jishnu Pramod - 2025-08-01 ✗ CITATION ✗ CODEOWNERS
  5. Hendrik Strobelt - 2025-08-05 ✓ CITATION ✓ CODEOWNERS
  6. Xiaojie Guo - 2025-08-05 ✓ CITATION ✗ CODEOWNERS
  7. Kenneth Ocheltree - 2025-08-05 ✗ CITATION ✗ CODEOWNERS
  8. Mishal Dholakia - 2025-08-06 ✗ CITATION ✗ CODEOWNERS
  9. Aashka Trivedi - (early) ✗ CITATION ✗ CODEOWNERS
  10. Elron Bandel - 2025-08-19 ✓ CITATION ✗ CODEOWNERS
  11. Masataro Asai - 2025-09-17 ✓ CITATION ✓ CODEOWNERS
  12. Jake LoRocco - 2025-11-17 ✓ CITATION ✓ CODEOWNERS

Additional 31+ contributors: Alex Bozarth (✓ CODEOWNERS), Paul Schweigert (✓ CODEOWNERS), Nigel Jones (✓ CODEOWNERS), Fred Reiss, James Busche, Juan Cruz-Benito, Akihiko Kuroda (✓ CODEOWNERS), Alex Jenkins, Alexander Skula, Angelo Danducci (✓ CODEOWNERS), Avihu Dekel, BJ Hargrave, Bobby, Keerthi Ram, Keshav Ramji, Lucian Popa, Mariela Lanza, Mateus Devino, Prasanna Sattigeri, Serjik, Tulio Coppola, Yousef El-Kurdi, github-actions[bot], and more...

List 3: CODEOWNERS Team (@generative-computing/mellea-contributors - 10 members)

  1. Hendrik Strobelt (@HendrikStrobelt) ✓ CITATION ✓ Git
  2. Nathan Fulton (@nrfulton) ✓ CITATION ✓ Git
  3. Masataro Asai (@guicho271828) ✓ CITATION ✓ Git
  4. Avinash Balakrishnan (@avinash2692) ✓ CITATION ✓ Git
  5. Nigel Jones (@planetf1) ✗ CITATION ✓ Git
  6. Alex Bozarth (@ajbozarth) ✗ CITATION ✓ Git
  7. Akihiko Kuroda (@akihikokuroda) ✗ CITATION ✓ Git
  8. Angelo Danducci (@AngeloDanducci) ✗ CITATION ✓ Git
  9. Paul Schweigert (@psschwei) ✗ CITATION ✓ Git
  10. Jake LoRocco (@jakelorocco) ✓ CITATION ✓ Git

Special reviewers for /mellea/core/: @nrfulton, @jakelorocco


Cross-Reference Analysis

✓ In ALL three lists (5):

  1. Nathan Fulton
  2. Hendrik Strobelt
  3. Avinash Balakrishnan
  4. Masataro Asai
  5. Jake LoRocco

✓ In CITATION.cff but NOT in CODEOWNERS team (4):

  1. Elron Bandel - Has git commits (2025-08-19)
  2. Supriya Lall - NO git commits (design/planning)
  3. Xiaojie Guo - Has git commits (2025-08-05)
  4. Ja Young Lee - NO git commits (created logo)

✓ In CODEOWNERS team but NOT in CITATION.cff (5):

  1. Nigel Jones - Multiple git commits
  2. Alex Bozarth - Extensive git commits
  3. Akihiko Kuroda - Multiple git commits
  4. Angelo Danducci - Multiple git commits
  5. Paul Schweigert - Multiple git commits

✓ Have git commits but in NEITHER list (33+):

  • Early contributors: JJ Asghar (2nd commit!), Jishnu Pramod (3rd commit!), Kenneth Ocheltree, Mishal Dholakia, Aashka Trivedi
  • Others: Fred Reiss, James Busche, Juan Cruz-Benito, Alex Jenkins, Alexander Skula, Avihu Dekel, BJ Hargrave, Bobby, Keerthi Ram, Keshav Ramji, Lucian Popa, Mariela Lanza, Mateus Devino, Prasanna Sattigeri, Serjik, Tulio Coppola, Yousef El-Kurdi, and 16+ more

Key Insights

1. CODEOWNERS team is MORE current than CITATION.cff

  • CODEOWNERS includes 5 active contributors NOT in CITATION.cff
  • CODEOWNERS excludes 4 CITATION.cff authors (including 2 with no commits)

2. Early contributors were overlooked

  • JJ Asghar (2nd commit overall) is in NEITHER list
  • Jishnu Pramod (3rd commit overall) is in NEITHER list
  • Kenneth Ocheltree and Mishal Dholakia (early Aug 2025) are in NEITHER list

3. CITATION.cff has 2 non-code contributors

  • Supriya Lall (no commits)
  • Ja Young Lee (no commits, created logo)

Discussion Questions for PR

1. Should CITATION.cff align with CODEOWNERS team?

Add these 5 CODEOWNERS members to CITATION.cff:

  • Nigel Jones
  • Alex Bozarth
  • Akihiko Kuroda
  • Angelo Danducci
  • Paul Schweigert

FOR: Recognizes current active contributors, aligns with who actually maintains the project
AGAINST: CITATION.cff = founding team, not current maintainers

2. Should we add early contributors who committed before some CITATION.cff authors?

Add these early contributors:

  • JJ Asghar (2nd commit overall, before 5 CITATION.cff authors)
  • Jishnu Pramod (3rd commit overall, before 5 CITATION.cff authors)
  • Kenneth Ocheltree (same day as Hendrik/Xiaojie)
  • Mishal Dholakia (day after Hendrik/Xiaojie)

FOR: Recognizes early code contributions, more fair
AGAINST: Opens "where to draw the line" debates

3. Should we remove authors without git commits?

Remove:

  • Supriya Lall (no commits)
  • Ja Young Lee (no commits, but created logo)

FOR: Clear criteria (must have commits), aligns with CODEOWNERS approach
AGAINST: Valid non-code contributions, academic citations include non-code work

4. What about Elron Bandel and Xiaojie Guo?

They're in CITATION.cff but NOT in CODEOWNERS team:

  • Elron Bandel - Has commits (2025-08-19)
  • Xiaojie Guo - Has commits (2025-08-05)

Should they be added to CODEOWNERS team?


Options Summary

Option CITATION.cff Authors Changes Pros Cons
A: Keep as-is 9 (current) None Simple, preserves founding team Doesn't reflect current maintainers
B: Align with CODEOWNERS 10 +5 (Nigel, Alex, Aki, Angelo, Paul), -4 (Elron, Supriya, Xiaojie, Ja Young) Reflects current team Loses founding team history
C: Merge both lists 14 +5 (Nigel, Alex, Aki, Angelo, Paul) Most inclusive Very large list
D: Add early committers 13 +4 (JJ, Jishnu, Kenneth, Mishal) Recognizes early support Opens debates
E: Code only 7 -2 (Supriya, Ja Young) Clear criteria Excludes valid non-code work

My Recommendation: Option C (Merge both lists)

Rationale:

  1. CODEOWNERS team represents current active maintainers - they should be in CITATION.cff
  2. Original founding team should be preserved - they created the project
  3. 14 authors is reasonable for a project with 43+ contributors
  4. Clear criteria: Either founding team OR current CODEOWNERS member
  5. Keeps both non-code contributors (Supriya, Ja Young) as founding team

Proposed CITATION.cff (14 authors, alphabetical by last name):

  1. Masataro Asai (founding)
  2. Avinash Balakrishnan (founding + CODEOWNERS)
  3. Elron Bandel (founding)
  4. Alex Bozarth (CODEOWNERS)
  5. Angelo Danducci (CODEOWNERS)
  6. Nathan Fulton (founding + CODEOWNERS)
  7. Xiaojie Guo (founding)
  8. Akihiko Kuroda (CODEOWNERS)
  9. Nigel Jones (CODEOWNERS)
  10. Supriya Lall (founding, non-code)
  11. Ja Young Lee (founding, non-code)
  12. Jake LoRocco (founding + CODEOWNERS)
  13. Paul Schweigert (CODEOWNERS)
  14. Hendrik Strobelt (founding + CODEOWNERS)

Alternative: Keep as-is (Option A) if the team prefers CITATION.cff to remain a historical record of founding team only.

Comment thread CITATION.cff Outdated
Based on PR review feedback, removing CITATION.cff as GitHub's built-in citation feature is sufficient and avoids the complexity of determining original authors.

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
@ajbozarth
ajbozarth enabled auto-merge March 6, 2026 17:15
@ajbozarth
ajbozarth added this pull request to the merge queue Mar 6, 2026
Merged via the queue into generative-computing:main with commit 7e12a12 Mar 6, 2026
4 checks passed
@ajbozarth
ajbozarth deleted the chore/update-authors-584 branch March 6, 2026 17:48
akihikokuroda pushed a commit to akihikokuroda/mellea that referenced this pull request May 27, 2026
…uting#589)

* chore: update pyproject authors and add CITATION.cff

- Replace individual authors with Mellea Contributors team
- Add CITATION.cff with founding authors for academic citation

Closes generative-computing#584
Part of generative-computing#453

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>

* chore: remove CITATION.cff file

Based on PR review feedback, removing CITATION.cff as GitHub's built-in citation feature is sufficient and avoids the complexity of determining original authors.

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>

---------

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: update pyproject authors Clean up and streamline pyproject.toml

3 participants