Skip to content

fix: explicit PYTHONPATH for isolated test subprocesses (#593) #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
planetf1 merged 2 commits into from
Mar 9, 2026
Merged

fix: explicit PYTHONPATH for isolated test subprocesses (#593) #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0889b48
fix: explicit PYTHONPATH for isolated test subprocesses (#593)
planetf1 Mar 6, 2026
3748054
fix: respect existing PYTHONPATH in subprocess tests
planetf1 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions docs/examples/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,12 +498,25 @@ def __init__(self, **kwargs):
super().__init__(**kwargs)

def runtest(self):
import os
import pathlib

repo_root = str(pathlib.Path(__file__).parent.parent.parent.resolve())
env = os.environ.copy()
existing_pythonpath = env.get("PYTHONPATH", "")
env["PYTHONPATH"] = (
f"{existing_pythonpath}{os.pathsep}{repo_root}"
if existing_pythonpath
else repo_root
)

process = subprocess.Popen(
[sys.executable, self.path],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
text=True,
bufsize=1, # Enable line-buffering
env=env,
)

# Capture stdout output and output it so it behaves like a regular test with -s.
Expand Down
5 changes: 5 additions & 0 deletions test/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,11 @@ def _run_heavy_modules_isolated(session, heavy_modules: list[str]) -> int:
if markexpr:
cmd.extend(["-m", markexpr])

import pathlib

repo_root = str(pathlib.Path(__file__).parent.parent.resolve())
env["PYTHONPATH"] = f"{repo_root}{os.pathsep}{env.get('PYTHONPATH', '')}"

# Stream output in real-time while capturing for parsing
process = subprocess.Popen(
cmd,
Expand Down