fix: astream() last call issue (#618)#626
Merged
Merged
Conversation
- astream() on computed MOT now raises error - the last astream call does NOT contain the full text again. All astream() chunks concatenated will be the full text. Related tests are added/modified.
# Conflicts: # mellea/core/base.py
HendrikStrobelt
requested review from
a team,
jakelorocco and
nrfulton
as code owners
March 11, 2026 21:57
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
jakelorocco
approved these changes
Mar 12, 2026
jakelorocco
left a comment
jakelorocco
left a comment
Contributor
There was a problem hiding this comment.
lgtm; we should be sure to highlight this behavior change in our release notes
8 tasks
akihikokuroda
pushed a commit
to akihikokuroda/mellea
that referenced
this pull request
May 27, 2026
- astream() on computed MOT now raises error - the last astream call does NOT contain the full text again. All astream() chunks concatenated will be the full text. Related tests are added/modified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
Testing