fix: update hallucination_detection fixture for upstream NA enum addition - #918
Merged
ajbozarth merged 1 commit intoApr 23, 2026
Conversation
…tion The upstream YAML in ibm-granite/granitelib-rag-r1.0 added "NA" as a valid enum value for the faithfulness field. Update the test fixture to match, fixing test_canned_input[hallucination_detection] CI failure. Closes generative-computing#915 Assisted-by: Claude Code Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
jakelorocco
approved these changes
Apr 23, 2026
ajbozarth
enabled auto-merge
April 23, 2026 20:42
Merged
via the queue into
generative-computing:main
with commit Apr 23, 2026
abb8cc9
9 of 10 checks passed
akihikokuroda
pushed a commit
to akihikokuroda/mellea
that referenced
this pull request
May 27, 2026
…tion (generative-computing#918) The upstream YAML in ibm-granite/granitelib-rag-r1.0 added "NA" as a valid enum value for the faithfulness field. Update the test fixture to match, fixing test_canned_input[hallucination_detection] CI failure. Closes generative-computing#915 Assisted-by: Claude Code Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
The upstream YAML in
ibm-granite/granitelib-rag-r1.0added"NA"as a valid enum value for the faithfulness field inHallucinationOutputEntry(for sentences that do not contain factual claims requiring grounding, e.g. greetings or opinions). Thetest_canned_input/hallucination_detection.jsonfixture was not updated to match, causingtest_canned_input[hallucination_detection]to fail in CI. Same fix pattern as #897.Testing
Attribution