Skip to content

fix: add missing nav and fix cli ref - #922

Merged
AngeloDanducci merged 2 commits into
generative-computing:mainfrom
AngeloDanducci:ad-910
Apr 24, 2026
Merged

fix: add missing nav and fix cli ref#922
AngeloDanducci merged 2 commits into
generative-computing:mainfrom
AngeloDanducci:ad-910

Conversation

@AngeloDanducci

@AngeloDanducci AngeloDanducci commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Attribution

  • AI coding assistants used

@AngeloDanducci
AngeloDanducci requested a review from a team as a code owner April 24, 2026 04:55
@github-actions github-actions Bot added the bug Something isn't working label Apr 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@AngeloDanducci

Copy link
Copy Markdown
Contributor Author

Adds the missing pi/mellea/telemetry/context to nav.

Also I don't think CLI was wiped per the issue - it was removed from the api docs in #852.
Updated to point to the CLI reference instead of generating.

@ajbozarth

ajbozarth commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Looks good — both fixes are correct. One thing worth addressing before merge: the stale "group": "cli" block is still in docs.json referencing pages that no longer exist. Either run poe apidocs and commit the result, or remove that cli group manually.

@AngeloDanducci
AngeloDanducci force-pushed the ad-910 branch 2 times, most recently from 6e1299f to 40e36e6 Compare April 24, 2026 18:48
@AngeloDanducci

Copy link
Copy Markdown
Contributor Author

Should be fixed, thanks!

@AngeloDanducci
AngeloDanducci added this pull request to the merge queue Apr 24, 2026
Merged via the queue into generative-computing:main with commit 3901c0e Apr 24, 2026
7 checks passed
@AngeloDanducci
AngeloDanducci deleted the ad-910 branch April 24, 2026 19:40
akihikokuroda pushed a commit to akihikokuroda/mellea that referenced this pull request May 27, 2026
* add missing nav and fix cli ref

* remove stale group cli block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs.json nav is stale — missing telemetry/context entry, CLI pages wiped on build

2 participants