ipv6: tcp: fix panic in SYN processing

Eric Dumazet · davem330 · commit c16a98ed9159 · 2011-11-23T15:49:31.000-05:00
commit 72a3eff ([NET]: Size listen hash tables using backlog hint) added a bug allowing inet6_synq_hash() to return an out of bound array index, because of u16 overflow. Bug can happen if system admins set net.core.somaxconn & net.ipv4.tcp_max_syn_backlog sysctls to values greater than 65536 Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c
@@ -85,7 +85,7 @@ struct dst_entry *inet6_csk_route_req(struct sock *sk,
  * request_sock (formerly open request) hash tables.
  */
 static u32 inet6_synq_hash(const struct in6_addr *raddr, const __be16 rport,
-			   const u32 rnd, const u16 synq_hsize)
+			   const u32 rnd, const u32 synq_hsize)
 {
 	u32 c;
 

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ struct dst_entry inet6_csk_route_req(struct sock sk,`
`85`	`85`	`* request_sock (formerly open request) hash tables.`
`86`	`86`	`*/`
`87`	`87`	`static u32 inet6_synq_hash(const struct in6_addr *raddr, const __be16 rport,`
`88`		`- const u32 rnd, const u16 synq_hsize)`
	`88`	`+ const u32 rnd, const u32 synq_hsize)`
`89`	`89`	`{`
`90`	`90`	`u32 c;`
`91`	`91`