fix: allow colon before appDistZip in task-detection grep(DCD-5100) - #419
Merged
Conversation
Multi-module gradle builds list subproject tasks as e.g. tam-deploy:appDistZip — the word-boundary regex added in 87065f4 didn't account for the colon, so appDistZip was never detected and the JFrog scan step was silently skipped for every client.
abhinav-genesis
requested review from
Namitha-genesis,
Tanmay-Genesis,
perryking and
pmakwanalcap
as code owners
July 27, 2026 05:44
Contributor
|
🤖 Hi @abhinav-genesis, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Contributor
There was a problem hiding this comment.
📋 Review Summary
This pull request correctly resolves an issue where the Gradle task detection logic fails to identify appDistZip when it is part of a multi-module project (such as tam-deploy:appDistZip). The proposed regex adjustment is a highly precise and targeted fix that preserves existing functionality while adding support for subproject task prefixes.
🔍 General Feedback
- Robustness: The regex update safely includes
:within the prefix match, which is the standard separator for Gradle multi-module tasks. - Accuracy: Testing confirms that this pattern matches expected subproject tasks (e.g.
tam-deploy:appDistZip), root-level tasks, and indented tasks, while avoiding false matches on partially matching words. - Safety: The change has no impact on existing single-module workflows and introduces no performance or security risks.
Tanmay-Genesis
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-module gradle builds list subproject tasks as e.g. tam-deploy:appDistZip — the word-boundary regex added in 87065f4 didn't account for the colon, so appDistZip was never detected and the JFrog scan step was silently skipped for every client.