Skip to content

fix: allow colon before appDistZip in task-detection grep(DCD-5100) - #419

Merged
abhinav-genesis merged 1 commit into
developfrom
fix/appdistzip-grep-regex
Jul 27, 2026
Merged

fix: allow colon before appDistZip in task-detection grep(DCD-5100)#419
abhinav-genesis merged 1 commit into
developfrom
fix/appdistzip-grep-regex

Conversation

@abhinav-genesis

Copy link
Copy Markdown
Contributor

Multi-module gradle builds list subproject tasks as e.g. tam-deploy:appDistZip — the word-boundary regex added in 87065f4 didn't account for the colon, so appDistZip was never detected and the JFrog scan step was silently skipped for every client.

Multi-module gradle builds list subproject tasks as e.g.
tam-deploy:appDistZip — the word-boundary regex added in 87065f4
didn't account for the colon, so appDistZip was never detected
and the JFrog scan step was silently skipped for every client.
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hi @abhinav-genesis, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This pull request correctly resolves an issue where the Gradle task detection logic fails to identify appDistZip when it is part of a multi-module project (such as tam-deploy:appDistZip). The proposed regex adjustment is a highly precise and targeted fix that preserves existing functionality while adding support for subproject task prefixes.

🔍 General Feedback

  • Robustness: The regex update safely includes : within the prefix match, which is the standard separator for Gradle multi-module tasks.
  • Accuracy: Testing confirms that this pattern matches expected subproject tasks (e.g. tam-deploy:appDistZip), root-level tasks, and indented tasks, while avoiding false matches on partially matching words.
  • Safety: The change has no impact on existing single-module workflows and introduces no performance or security risks.

@abhinav-genesis
abhinav-genesis merged commit ac49dd2 into develop Jul 27, 2026
8 checks passed
@abhinav-genesis
abhinav-genesis deleted the fix/appdistzip-grep-regex branch July 27, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants