fix: composite the sonarcloud analysis (DCD-5103)

[LukasKuzavas]

https://genesisglobal.atlassian.net/browse/DCD-5103

composite the sonarcloud analysis, to lessen complexity, to fix coverage analysis

[github-actions]

🤖 Hi @LukasKuzavas, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

[github-actions]

📋 Review Summary

This Pull Request refactors SonarCloud analysis by replacing the reusable workflow .github/workflows/sonarcloud.yml with a composite action sonarcloud/action.yaml. The analysis is now executed as a step directly within the build-server job, which simplifies the pipeline, eliminates the need to upload and download large build artifacts, and ensures consistent coverage reports.

🔍 General Feedback

• Significant Efficiency Gains: Moving the SonarCloud analysis inline with the build job is a massive improvement. It avoids the overhead of uploading and downloading large classes and report artifacts, leading to faster CI runtimes and cleaner workspace state reuse.
• Potential Breaking Change for External Caller Repos: Since .github/workflows/sonarcloud.yml has been completely deleted, any other repositories in the organization that reference this file as a reusable workflow (via uses: genesislcap/appdev-workflows/.github/workflows/sonarcloud.yml@...) will fail. Please double-check if any external repositories rely on this workflow and coordinate their migration to the new composite action genesislcap/appdev-workflows/sonarcloud@develop.

[github-actions]

🟡 Passing the Sonar token via the -Dsonar.token command line option is redundant because the SONAR_TOKEN environment variable is already provided in the environment (on line 52). Removing it avoids passing sensitive tokens as command-line arguments, which can be visible in process listings or system logs.

Suggested change

	arguments: >-
	sonar --no-configuration-cache
	${{ inputs.gradle-arguments }}
	-Dsonar.gradle.skipCompile=true
	-Dsonar.token=${{ inputs.sonar-token }}
	arguments: >-
	sonar --no-configuration-cache
	${{ inputs.gradle-arguments }}
	-Dsonar.gradle.skipCompile=true