Skip to content

Fix parse error in pop3.receive when addresses are separated by semicolons #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomas-sexenian merged 2 commits into from
Sep 8, 2023
Merged

Fix parse error in pop3.receive when addresses are separated by semicolons #769

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46532b0
Fix parse error when pop3.recive addresses are separated by semicolons
Sep 6, 2023
740bd88
Only catch AddressException and parse splitAddress using InternetAddress
Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions gxmail/src/main/java/com/genexus/internet/POP3SessionJavaMail.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import jakarta.mail.NoSuchProviderException;
import jakarta.mail.Part;
import jakarta.mail.Session;
import jakarta.mail.internet.AddressException;
import jakarta.mail.internet.InternetAddress;
import jakarta.mail.internet.MimeMessage;
import jakarta.mail.internet.MimeUtility;
Expand Down Expand Up @@ -239,15 +240,34 @@ private MailRecipient getMailRecipient(InternetAddress inetAdd)
private MailRecipientCollection processRecipients(Message message, Message.RecipientType rType) throws MessagingException
{
MailRecipientCollection mailRecipient = new MailRecipientCollection();
if (message.getRecipients(rType) != null)
{
for (int i = 0 ; i < message.getRecipients(rType).length; i++)
try {
if (message.getRecipients(rType) != null)
{
InternetAddress address = (InternetAddress)message.getRecipients(rType)[i];
mailRecipient.addNew(address.getPersonal(), address.getAddress());
}
for (int i = 0 ; i < message.getRecipients(rType).length; i++)
{
InternetAddress address = (InternetAddress)message.getRecipients(rType)[i];
mailRecipient.addNew(address.getPersonal(), address.getAddress());
}
}
return mailRecipient;
} catch (AddressException e) {
/*
Some email clients like Gmail separate the list of addresses using commas while others like Outlook separate them using
semicolons. This is a hack to consider the case where the list of addresses is separated with semicolons which produces
an exception because the InternetAddress class used by jakarta mail to parse the addresses expects the list to be separated by commas
*/
String[] addresses = message.getHeader(rType.toString());
if (addresses != null && addresses.length > 0) {
for (String address : addresses) {
String[] splitAddresses = address.split(";");
for (String splitAddress : splitAddresses){
InternetAddress ia = new InternetAddress(splitAddress);
mailRecipient.addNew(ia.getPersonal(),ia.getAddress());
}
}
}
return mailRecipient;
}
return mailRecipient;
}

private void handleMultipart(Multipart multipart, GXMailMessage gxmessage) throws MessagingException, IOException
Expand Down