Use sqlalchemy outerjoin for compability reasons - #192
Closed
mkofahl wants to merge 1 commit into
Closed
Conversation
… join(.., isouter=True).
Contributor
|
AFAIR, I used |
Contributor
Author
|
Tested with sqlite3 3.8.7.1-1+deb8u2 in terms it's not crashing. It's definitly not a very forward-looking PR. So I'm fine not merging it, but maybe it helps someone else having trouble with GHC and an can only join an iterable error. |
Member
|
Closing: has been open for over a year, please open issue if relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a suggestion: allow use of older sqlalchemy versions by using
outerjoin()instead ofjoin(.., isouter=True). In some environments python modules may have to be used from the distro, so packages may be slightly out-of-date. I recognized the requirements.txt, but for now this fix allows me to keep on running this software.