Fix connecting SMTP on localhost only

[mkofahl]

Fix connecting localhost by calling connect() on an already initialized smtplib object, introduced in 5ef60b3. According to the docs, smtplib.SMTP() calls the connect method for the given host. Calling connect again but without any parameters will fall back to smtplibs default, which is localhost:25.

[justb4]

I need to understand the rationale for this PR, according to the docs:

 server = smtplib.SMTP(config['GHC_SMTP']['server'],
                          config['GHC_SMTP']['port'])

will already connect(). As config['GHC_SMTP']['server'] and config['GHC_SMTP']['port'] should always be set (see check at notifications.py#L85), I don't see the need for calling server.connect(). But I could be missing something here. In all deployments up to now we have been using SSL/TLS so this case may have never emerged.

[ghost]

After doing some tests with @tomkralidis on our version of GeoHealthCheck, we discovered that we needed those changes in order to resolve an issue that we had with the email notifications. After applying them, our notifications worked again.

Thanks.

[justb4]

Sorry folks I overlooked: yes indeed:

• GHC requires host and port in GHC_SMTP config (when email notif enabled)
• smtplib.SMTP() constructor always calls connect() when/with host+port specified
• GHC should not call connect() again (defaults to localhost:25)
• problem only will popup when SSL/TLS is not used (and host=otherhost port=any)

So merging!

[justb4]

Thanks for patience!

[justb4]

All good!