Fix for #133 use requests Session object with Retry capabilities - #319
Merged
Conversation
Member
Author
|
@tomkralidis @borrob merging anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix should improve HTTP connection handling by GHC
Probessignificantly:requestsSessionobjects to reuse connections (works viaurllib3)Probeobject aSessionwith a retry/backoff schema is created.requestspackage to latest version 2.23.0Especially in Probes where all N Layers of a WMS/Tiling endpoint are accessed/crawled this already gives a factor 3 performance improvement. In the old case a new connection was setup for each request.
The false negatives should be of the past. Will first observe for some time on the GHC demo server (where I get this stream of Failing/Fixed emails constantly...).
OPTION for later: may make this mechanism and its parameters configurable.