Skip to content

use flag instead of for-else in csw:retrecords#919

Merged
tomkralidis merged 2 commits into
geopython:masterfrom
pvgenuchten:for_else_should_be_on_outer_loop
Apr 4, 2024
Merged

use flag instead of for-else in csw:retrecords#919
tomkralidis merged 2 commits into
geopython:masterfrom
pvgenuchten:for_else_should_be_on_outer_loop

Conversation

@pvgenuchten
Copy link
Copy Markdown
Contributor

for-else works on break in outer loop only, so replace by flag on a xml-url being found

resolves #917

@pvgenuchten pvgenuchten force-pushed the for_else_should_be_on_outer_loop branch from 402552e to 68cb141 Compare April 4, 2024 19:48
pvgenuchten added a commit to pvgenuchten/OWSLib that referenced this pull request Apr 4, 2024
@pvgenuchten pvgenuchten closed this Apr 4, 2024
@pvgenuchten pvgenuchten reopened this Apr 4, 2024
fix flake8 error
@pvgenuchten pvgenuchten force-pushed the for_else_should_be_on_outer_loop branch from 68cb141 to 46c541d Compare April 4, 2024 20:23
@tomkralidis tomkralidis merged commit 71e64bd into geopython:master Apr 4, 2024
pvgenuchten added a commit to pvgenuchten/OWSLib that referenced this pull request Apr 4, 2024
tomkralidis pushed a commit that referenced this pull request Apr 4, 2024
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 5, 2024

Coverage Status

coverage: 59.929% (-0.01%) from 59.942%
when pulling 46c541d on pvgenuchten:for_else_should_be_on_outer_loop
into 2f00ab8 on geopython:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

on csw:getrecords, incorrect endpoint is used

3 participants