Removed dependency on the pytz library.#921
Closed
spillner wants to merge 0 commit into
Closed
Conversation
|
This Pull Request has been inactive for 90 days. In order to manage maintenance burden, it will be automatically closed in 7 days. |
Contributor
Author
|
Pinging the issue to prevent an auto-close. It looks like the CI pipelines were timing out due to a test harness issue that has nothing to do with this change, and the "conflict" in requirements.txt is a fundamental part of the patch. Anyway, LMK if there's anything else you're looking for me to do to package this up. |
Contributor
|
@spillner - the merge conflict is due to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the Pytz functionality is now available in the standard library in 3.8 and greater, and the Pytz (https://pypi.org/project/pytz/) project has gone into maintenance mode and is no longer recommended for new projects. I noticed that OWSLib was using Pytz only to annotate timestamps as UTC, which doesn't even require the expanded tzinfo support from 3.8/3.9+; the attached patch supports Python 2 (at least Python 2.7) as well.