Skip to content

add a null check before using attrib #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomkralidis merged 4 commits into from
Mar 8, 2025
+2,015 −5
Merged

add a null check before using attrib #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a99daed
resolves issue #973
pvgenuchten Mar 1, 2025
f78b9cf
Add pytest_httpserver and unit test
geographika Mar 6, 2025
47de71b
Remove live server URL
geographika Mar 6, 2025
9808cc0
Mark online
geographika Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions owslib/iso.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,11 +224,14 @@ def __init__(self, md=None):
self.charset = None
else:
self.id = md.attrib.get('id')
self.languagecode = md.find(
util.nspath_eval('gmd:languageCode/gmd:LanguageCode', namespaces)).attrib.get('codeListValue')
self.charset = md.find(
util.nspath_eval('gmd:characterEncoding/gmd:MD_CharacterSetCode', namespaces)).attrib.get(
'codeListValue')
self.languagecode = None
languagecode = md.find(util.nspath_eval('gmd:languageCode/gmd:LanguageCode', namespaces))
if languagecode is not None:
self.languagecode = languagecode.attrib.get('codeListValue')
self.charset = None
charset = md.find(util.nspath_eval('gmd:characterEncoding/gmd:MD_CharacterSetCode', namespaces))
if charset is not None:
self.charset = charset.attrib.get('codeListValue')


class CI_Date(object):
Expand Down
1 change: 1 addition & 0 deletions requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
flake8
pytest
pytest-cov
pytest_httpserver
pytest-socket
Pillow
tox
Expand Down
Loading