ModuleNotFoundError: No module named 'jsonpatch'

[krishnaglodha]

Description
I'm trying to execute Install in 5 minutes on https://pygeoapi.io/ , and getting above mentioned error.

Steps to Reproduce
Steps to reproduce the behavior:

python3 -m venv pygeoapi
cd pygeoapi
. bin/activate
git clone https://github.com/geopython/pygeoapi.git
cd pygeoapi
pip3 install -r requirements.txt
python3 setup.py install
cp pygeoapi-config.yml example-config.yml
vi example-config.yml  # edit as required
export PYGEOAPI_CONFIG=example-config.yml
export PYGEOAPI_OPENAPI=example-openapi.yml
pygeoapi openapi generate $PYGEOAPI_CONFIG --output-file $PYGEOAPI_OPENAPI
pygeoapi serve

Screenshots/Tracebacks

Environment

• OS: Mac OS
• Python version: 3.11
• pygeoapi version: latest

[krishnaglodha]

Should we mention it on the admin page that to run is successfully, user should also execute pip install -r requirements-admin.txt

[doublebyte1]

@krishnaglodha well spotted! 👍🏽 Do you want to do a PR to add that line to the docs?

pygeoapi/docs/source/installation.rst

Line 29 in d66e790

pip3 install -r requirements.txt

+ pip3 install -r requirements-admin.txt

[krishnaglodha]

Will do Thanks & Regards, Krishna G. Lodha Founder office email - ***@***.*** personal email - ***@***.***

…

On 4 Jan 2024 at 03:21 +0530, Jo ***@***.***>, wrote: @krishnaglodha well spotted! 👍🏽 Do you want to do a PR to add that line to the docs? https://github.com/geopython/pygeoapi/blob/d66e790df18ddcaa984984c2cb6a25c97c21bdee/docs/source/installation.rst?plain=1#L29 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[krishnaglodha]

I propose to have this on the doc page of admin, because we are not sure that everyone will be using admin function, thus, let people know about this only on admin doc page ?

[ricardogsilva]

@krishnaglodha

If that would be the case, then the packages specified on requirements-admin.txt ought to be optional, which does not seem to be the case currently, which I guess is a bug?

The admin is being turned on conditionally, depending on the pygeoapi config. However, the import of jsonpatch happens regardless.

[ricardogsilva]

I guess a decision needs to be taken on whether:

• The admin is part of the default pygeoapi experience, in which case I guess there is no need for a separate requirements-admin.txt file and the admin dependencies become regular pygeoapi dependencies - no need to modify the installation docs in this case.

• The admin is indeed optional, in which case the docs need to be adjusted and the code needs to include some guards that ensure the admin dependencies are not imported unconditionally

@tomkralidis @webb-ben , what would be your thoughts on this?

[doublebyte1]

The admin is being turned on conditionally, depending on the pygeoapi config. However, the import of jsonpatch happens regardless.

@ricardogsilva indeed that does not seem correct.

I am in favour of the second option (admin as optional). I can think of use cases where people don't need an admin UI and just want a simple, lightweight, API.

[tomkralidis]

PR in #1485