Fix feature labels for docs.rs#138
Merged
bors[bot] merged 2 commits intogeorust:masterfrom Sep 3, 2020
Merged
Conversation
michaelkirk
approved these changes
Sep 3, 2020
Member
michaelkirk
left a comment
michaelkirk
left a comment
There was a problem hiding this comment.
Thanks! Feel free to merge after addressing or declining my optional feedback.
src/conversion/from_geo_types.rs
Outdated
| @@ -1,3 +1,7 @@ | |||
| // only enables the `doc_cfg` feature when | |||
| // the `docsrs` configuration attribute is defined | |||
| #[cfg_attr(docsrs, feature(doc_cfg))] | |||
Member
There was a problem hiding this comment.
No biggie, so take it or leave it, but can we do this in a single place, like at src/lib.rs or does it need to be duplicated around?
Member
Author
There was a problem hiding this comment.
I have no idea, but that would be better. I'll ask elsewhere…
Member
There was a problem hiding this comment.
Tokio does it in the crate root - so seems like it should work.
https://github.com/tokio-rs/tokio/blob/master/tokio/src/lib.rs#L18
Member
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #136 (comment)
See here: https://stackoverflow.com/a/61417700/416626