Skip to content

#12094: Fix dropdown menu overflow when adding links to text widget in TextEditor#12260

Merged
MV88 merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:issue_12094
Apr 15, 2026
Merged

#12094: Fix dropdown menu overflow when adding links to text widget in TextEditor#12260
MV88 merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:issue_12094

Conversation

@mahmoudadel54
Copy link
Copy Markdown
Contributor

@mahmoudadel54 mahmoudadel54 commented Apr 15, 2026

Description

This PR includes:

  • Add linkModalDirection prop to CompactRichTextEditor to control dropdown positioning and prevent off-screen overflow when adding links in the dashboard editor and edit annotation screen

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#12094

What is the new behavior?

For dashboard:

image

For Annotations:

annotation in map viewer

For feature info edit:

feature info editor

For map views:

MapViews desc

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

The fix has inspired from jpuri/react-draft-wysiwyg#664 (comment)

…o text widget in TextEditor

Description:
- Add linkModalDirection prop to CompactRichTextEditor to control dropdown positioning and prevent
off-screen overflow when adding links in the dashboard editor and edit annotation screen
- add unit test
@mahmoudadel54 mahmoudadel54 added this to the 2026.01.01 milestone Apr 15, 2026
@mahmoudadel54 mahmoudadel54 requested a review from MV88 April 15, 2026 09:47
@mahmoudadel54 mahmoudadel54 self-assigned this Apr 15, 2026
@cla-bot cla-bot bot added the CLA Ready label Apr 15, 2026
@mahmoudadel54 mahmoudadel54 linked an issue Apr 15, 2026 that may be closed by this pull request
1 task
@MV88 MV88 merged commit 9873eeb into geosolutions-it:master Apr 15, 2026
15 checks passed
@offtherailz
Copy link
Copy Markdown
Member

dsuren1 added a commit to anup39/MapStore2 that referenced this pull request Apr 16, 2026
…log_refactor_genode_int_11930

* commit 'de55770d13eb703b5b6cfe31ae55f38fea0b9fcf':
  Fix geosolutions-it#12146: ArcGIS support for FeatureService (geosolutions-it#12235)
  geosolutions-it#12094: Fix dropdown menu overflow when adding links to text widget in TextEditor (geosolutions-it#12260)
  geosolutions-it#12207: Fix - ScaleBox plugin - Custom scales not reported on map load (geosolutions-it#12212)
  fix a few danish translations (geosolutions-it#12230)
  geosolutions-it#12223: fix rule manager field filtering with checkbox is not working properly (geosolutions-it#12224)
  geosolutions-it#12218: fix pagination in rules manager layers autocomplete does not work (geosolutions-it#12219)
  Fix geosolutions-it#12213 - Fixed startup script for java new versions (geosolutions-it#12214)
  Update Changelog for version 2025.02.03 (geosolutions-it#12211)
  Fix pre-release gh action workflow for CLA (geosolutions-it#12205)
  Update Changelog for version 2026.01.00 (geosolutions-it#12202)
  fix geosolutions-it#12162 flatgeobuf params by getRequestConfigurationByUrl (geosolutions-it#12200)
  Fix geosolutions-it#12162 COG and FlatGeobuf layers support params for protected storage (geosolutions-it#12179)
  Fix doc of MapImport plugin (geosolutions-it#12197)
  Fix geosolutions-it#12044: fix wfs layer hidden in 3D + scale arrow not rendering (geosolutions-it#12155)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link popup overflows on dashboard text editor

3 participants