Skip to content

fix(app-server): surface turn errors and process events#17

Merged
gersmann merged 1 commit into
mainfrom
fix/app-server-stream-events/sg
May 20, 2026
Merged

fix(app-server): surface turn errors and process events#17
gersmann merged 1 commit into
mainfrom
fix/app-server-stream-events/sg

Conversation

@gersmann
Copy link
Copy Markdown
Owner

Summary

  • surface non-retryable turn error notifications as AppServerTurnError and deliver terminalInteraction events on turn streams
  • add typed event subscriptions for command/exec output and process output/exit notifications keyed by process id/handle
  • cover retryable errors, non-retryable errors, terminalInteraction delivery, and process event filters

Verification

  • uv run --group dev pytest tests/test_app_server_client.py tests/test_app_server_async_client.py tests/test_stream_interaction.py -q
  • make lint
  • git diff --check

@gersmann gersmann marked this pull request as ready for review May 20, 2026 11:31
@gersmann gersmann force-pushed the fix/app-server-stream-events/sg branch from 78e0030 to 5d06e08 Compare May 20, 2026 11:41
@github-actions
Copy link
Copy Markdown
Contributor

Codex Autonomous Review:

  • Overall: patch is correct
  • New findings this run: 0
  • Prior unresolved Codex findings still relevant: 0
  • Active findings total: 0

The changes add terminalInteraction delivery, surface non-retryable turn errors with appropriate closure, and introduce targeted event subscriptions. Implementations align with protocol types and updated tests without introducing regressions.

Tip: comment with "/codex address comments" to attempt automated fixes for unresolved review threads.

@gersmann gersmann merged commit 407494b into main May 20, 2026
3 checks passed
@gersmann gersmann deleted the fix/app-server-stream-events/sg branch May 20, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant