chore: rename ISO filenames - #69
Conversation
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull request overview
This PR updates the ISO/artifact filename format produced by the reusable Anaconda ISO build workflow, removing the hardcoded -webui- segment so generated ISO filenames better reflect the actual build variant.
Changes:
- Adjust
artifact_formatoutput to drop the-webui-suffix from generated ISO filenames.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
I generally like the idea, the installer should not matter for the iso names. But what do we do if we at some point make an iso that for example doesn't use anaconda, or titanoboa and needs to be tested over a longer period of time? Would the -testing suffix be good enough and the changes don't matter enough to change file names going forward? I at least think so. This will likely break things again when others are relying on this naming scheme we use now. Notably FOSS torrents |
I think we can just add a suffix to those then. I think we did this back when the old installer was the default still and then it kind of just stuck when we moved to this one. Fosstorrents has been broken for ages for our images (they don't even have torrents for us at the moment) since their hardware broke. also related ublue-os/aurora-docs#395 I have asked them multiple times if they are going to fix it but nothing has happened |
I think we should have a stable naming scheme that is without -webui, -readymade, -whatever. It frankly doesn't matter what installer we are using. If we ever want to get into things like https://gitlab.com/libosinfo/osinfo-db/-/blob/7be6d2fd219712789d487fb06d981d07614ecffb/data/os/archlinux.org/archlinux-rolling.xml.in#L57 for VM auto-detection then this is important. Get rid of the suffixes forever. We didn't have a testing bucket when we made those decisions in the past. |
agree. What I meant was for the "stable" ISOs that are on the website/docs we should just use normal naming scheme and for possible testing ISOs we can have a different naming or whatever, as they go to testing bucket anyway. In that sense, we might consider just dropping the -stable suffix too if we want. |
I think only for simplicity sake we should probably keep the -stable, or else we'd have aurora-x86.iso and then we'd have aurora-testing-readymade-x86.iso it is more descriptive yes. But I really think we should just keep things simple. |
Remove the un-needed webui from the ISO filenames
related: ublue-os/aurora-docs#396
related: get-aurora-dev/aurora-web#315