Skip to content

Feature/leytech 20220714#3

Open
bluec wants to merge 6 commits into
getAddress:mainfrom
bluec:feature/leytech-20220714
Open

Feature/leytech 20220714#3
bluec wants to merge 6 commits into
getAddress:mainfrom
bluec:feature/leytech-20220714

Conversation

@bluec
Copy link
Copy Markdown

@bluec bluec commented Jul 14, 2022

A few minor fixes and improvements...

Copy link
Copy Markdown
Contributor

@LeePaulSmith LeePaulSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but without the version suffix the browser will always use it's cached version. It will not know the file has changed.

@bluec
Copy link
Copy Markdown
Author

bluec commented Jul 14, 2022

That's a fair point especially for anyone linking to the CDN version. I have left the version suffix in there too so yes I agree the README should still link to that.

However, for anyone who uses this library via NPM and build tools like webpack etc its nice for them to have the option to not have to manually update their build with the version number each time they update the package.

@bluec
Copy link
Copy Markdown
Author

bluec commented Jul 14, 2022

I have put the version number back in the README link.

@LeePaulSmith
Copy link
Copy Markdown
Contributor

Thanks, but if you're importing in to NPM you would use the non-versioned JS module. Only the iife version is published to the CDN:
(package.json)
"main": "dist/getaddress-find.mjs",

@bluec
Copy link
Copy Markdown
Author

bluec commented Jul 14, 2022

I hadn't spotted that thanks. I have reverted/removed the build changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent from clearing the bound inputs when a new search is initiated Set initial value of the input field

2 participants