fix: menubar auto refresh stops working after idle#137
Merged
Conversation
The menubar price would freeze after the app was idle for a while because macOS App Nap suspends Task.sleep even with beginActivity. Replace Task.sleep with DispatchSourceTimer which is more robust for background execution. Also add observers for system wake and screen wake events to force a refresh when the Mac resumes from sleep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The menubar price freezes after the app is idle for a while. This happens because macOS App Nap suspends Task.sleep even when beginActivity is set.
This PR replaces Task.sleep with DispatchSourceTimer which keeps firing reliably in background. It also adds observers for system wake and screen wake events to force an immediate refresh when the Mac resumes from sleep.
Tested by leaving the app running for extended periods while using other applications.