Immediate version info update on CBLoader#339
Conversation
|
Nice one David. I've added write permissions to you, so you can assign a label and request a review from e.g. @BigRoy. You're able to merge as well, just bear in mind to let everyone get a chance to see a PR first, at least 24 hours since the last commit. |
|
Big thanks @mottosso ! |
|
David, this is sweet. Thanks! I actually am working on another "version widget" that shows all comments, bu this is already great. Nice job. |
|
|
||
| self.setEnabled(True) | ||
|
|
||
| print("Querying..") |
There was a problem hiding this comment.
Was this for debugging purposes, or is this a logical message to display for the end user?
There was a problem hiding this comment.
It's not for the end user, my motivation was to know when will the actual database querying happen after this implementation, I thought it would be nice to know that for developer, so yeah, it should count as debugging purposes.
There was a problem hiding this comment.
Sure - we can keep it. If it's too verbose later on we can always tone it down.
|
Looks good to me, feel free to merge. |
3 participants
Before:
The change of version in subset view, require re-select subset so the version widget will update.
After:
Now the version widget will update immediately with reasonable database query counts.
You can scroll the version list and view comments smoothly.
Minor tweak