Skip to content

Hotfix/nuke pipeline little fixes#441

Closed
jakubjezek001 wants to merge 238 commits into
getavalon:masterfrom
ynput:hotfix/nuke-pipeline-little-fixes
Closed

Hotfix/nuke pipeline little fixes#441
jakubjezek001 wants to merge 238 commits into
getavalon:masterfrom
ynput:hotfix/nuke-pipeline-little-fixes

Conversation

@jakubjezek001
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Avalon! Here's how you can get your code merged quickly.

What's changed?
Briefly summarise the changes you've made, something human-readable to get the reader up-to-speed with your thought process (hint: everyone loves bullet-lists). If the PR is in response to an existing issue (it should), link to this here.

Health Check
To ensure your code lives up the standards of Avalon, consult the Pull-Request section of CONTRIBUTION.md for details.

Examples
If you are unsure of how to format your pull-request, have a look at these examples. #403, #400

mkolar and others added 30 commits December 13, 2018 21:34
Fixed dynamicall environment.
…onments-to-launcher

Feature/pype 50 add dynamic environments to launcher
hiearchy in asset model is creating right now
…ojects widget don't create multipletimes, install project config added
…and redo few methods from avalon.pipeline and libs
mkolar and others added 28 commits August 4, 2019 22:30
nuke_publish_create_load with new attributes
…ish_state

Set write node publish default to True.
…mand

Ensure the work root exists instead of throwing an error.
# Conflicts:
#	avalon/tools/cbloader/app.py
#	avalon/tools/cbloader/widgets.py
#	avalon/tools/cbsceneinventory/app.py
#	avalon/tools/libraryloader/models/model_subsets.py
#	avalon/tools/workfiles/README.md
#	avalon/tools/workfiles/app.py
fix(nk): adding return node to containerized method
select_assets expect list or tuple but single item is feeded as str. Therefor switching context doesn't work. String is converted to list and all is ok.
select_assets expect list or tuple
result[key] = value

return result

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line at end of file


Yields tuple (progress, error):
progress (int): Between 0-100
error (Exception): Any exception raised when first making connection
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (80 > 79 characters)

output = []
if entity.get('data', {}).get('visualParent', None) is None:
return output
parent = io.find_one({'_id': entity['data']['visualParent']})
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined name 'io'


def collect_data(self):
project = io.find_one({'type': 'project'})
asset = io.find_one({'_id': self.get_active_asset()})
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined name 'io'

self.view = view

def collect_data(self):
project = io.find_one({'type': 'project'})
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined name 'io'

"config": {
"families": [
{"name": "avalon.camera", label: "Camera", "icon": "photo"},
{"name": "avalon.anim", label: "Animation", "icon": "male"},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (80 > 79 characters)

{
"config": {
"families": [
{"name": "avalon.camera", label: "Camera", "icon": "photo"},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (80 > 79 characters)

)


def refresh(self):
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many blank lines (2)

from .proxy_recursive_sort_filter import RecursiveSortFilterProxyModel
from .proxy_group_filter import GroupMemberFilterProxyModel
from .proxy_subset_filter import SubsetFilterProxyModel
from .proxy_family_filter import FamilyFilterProxyModel
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'.proxy_family_filter.FamilyFilterProxyModel' imported but unused

_id = io.ObjectId(item["representation"])
representation = io.find_one({
"type": "representation",
"_id": _id
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line missing indentation or outdented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants