Adds Typescript support for fix of issue #1771#1842
Merged
NivedhaSenthil merged 70 commits intogetgauge:masterfrom Feb 19, 2021
klhex:issue_1771_typescript_support
Merged
Adds Typescript support for fix of issue #1771#1842NivedhaSenthil merged 70 commits intogetgauge:masterfrom klhex:issue_1771_typescript_support
NivedhaSenthil merged 70 commits intogetgauge:masterfrom
klhex:issue_1771_typescript_support
Conversation
NivedhaSenthil
requested changes
Feb 5, 2021
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
…in various function definitions. Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Bumps [@babel/parser](https://github.com/babel/babel/tree/HEAD/packages/babel-parser) from 7.12.13 to 7.12.14. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.14/packages/babel-parser) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Bumps [chai](https://github.com/chaijs/chai) from 4.2.0 to 4.3.0. - [Release notes](https://github.com/chaijs/chai/releases) - [Changelog](https://github.com/chaijs/chai/blob/master/History.md) - [Commits](chaijs/chai@4.2.0...4.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Bumps [devtools-protocol](https://github.com/ChromeDevTools/devtools-protocol) from 0.0.849788 to 0.0.850520. - [Release notes](https://github.com/ChromeDevTools/devtools-protocol/releases) - [Commits](https://github.com/ChromeDevTools/devtools-protocol/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Bumps [@babel/parser](https://github.com/babel/babel/tree/HEAD/packages/babel-parser) from 7.12.14 to 7.12.15. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.15/packages/babel-parser) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Bumps [markdown-it-anchor](https://github.com/valeriangalliat/markdown-it-anchor) from 7.0.1 to 7.0.2. - [Release notes](https://github.com/valeriangalliat/markdown-it-anchor/releases) - [Changelog](https://github.com/valeriangalliat/markdown-it-anchor/blob/master/CHANGELOG.md) - [Commits](valeriangalliat/markdown-it-anchor@v7.0.1...v7.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 10.5.3 to 10.5.4. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v10.5.3...v10.5.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Bumps [husky](https://github.com/typicode/husky) from 4.3.8 to 5.0.9. - [Release notes](https://github.com/typicode/husky/releases) - [Commits](typicode/husky@v4.3.8...v5.0.9) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.1.3 to 4.1.4. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.1.3...v4.1.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Bumps [dtslint](https://github.com/Microsoft/dtslint) from 4.0.6 to 4.0.7. - [Release notes](https://github.com/Microsoft/dtslint/releases) - [Commits](https://github.com/Microsoft/dtslint/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.1.4 to 4.1.5. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.1.4...v4.1.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Bumps [devtools-protocol](https://github.com/ChromeDevTools/devtools-protocol) from 0.0.850520 to 0.0.852555. - [Release notes](https://github.com/ChromeDevTools/devtools-protocol/releases) - [Commits](https://github.com/ChromeDevTools/devtools-protocol/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
…ions, TapOptions extended with HiddenOrDisabledElementsOptions. Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
…k' and 'rightClick'. Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
…ionOptions. Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
…tionOptions for functions 'clear', 'hover', 'focus', 'mouseAction'. Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
|
@klhex Thank you for contributing to taiko. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
Member
|
Please resolve conflicts and update version for a release |
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
…t since I am not yet familiar w/ the corresponding git operations, I think in this case this has the lower risk of messing things up). Signed-off-by: klhex <71178731+klhex@users.noreply.github.com>
NivedhaSenthil
approved these changes
Feb 19, 2021
Member
|
Thanks for the contribution @klhex :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1771.
(Adds TS support for changes of #1819 relating to the new option
{ force: true }.)Please review. I could only test it for function
attachsince this is currently my only use case where I need to deal with hidden elements. Also since I'm a JS/TS beginner, I don't know whether my approach for adding TS support is the right one. But it was a low effort approach, so don't worry about deleting the PR if it's crap. 😄In this PR I also removed the leftover references to
SelectOptions, see here.