Update click.js for relative selectors#2747
Merged
NivedhaSenthil merged 5 commits intogetgauge:masterfrom Jan 2, 2025
Merged
Conversation
Contributor
Author
|
Do I need to re-submit for the DCO? Edit: I think I figured it out. Let me know if i need to do anything else |
If a Relative Selector is passed in as the third argument inside of click(), it doesn't actually make it down to waitAndGetActionableElement. We found that `await click(element, options, within(withinElement))` doesn't search in the "within" element Signed-off-by: DCoomer <deshuncoomer@gmail.com>
|
@DCoomer Thank you for contributing to taiko. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
| @@ -49,11 +49,11 @@ async function simulateInputEvents(options) { | |||
| } | |||
|
|
|||
| async function click(selector, options = {}, ...args) { | |||
Member
There was a problem hiding this comment.
Can we please add a unit test for this case ?
taiko/test/unit-tests/click.test.js
Line 149 in 6645c6d
Member
|
Thanks for the PR :) |
Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com>
NivedhaSenthil
approved these changes
Dec 26, 2024
Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com>
Contributor
Author
|
Updated the formatting 617b982 |
Member
|
Looks like it is still failing for format |
Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com>
Contributor
Author
|
Updated Again |
Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com>
Contributor
Author
|
Added the proper HTML for the unit test |
NivedhaSenthil
pushed a commit
that referenced
this pull request
Jan 3, 2025
* Update click.js for relative selectors If a Relative Selector is passed in as the third argument inside of click(), it doesn't actually make it down to waitAndGetActionableElement. We found that `await click(element, options, within(withinElement))` doesn't search in the "within" element Signed-off-by: DCoomer <deshuncoomer@gmail.com> * Updated Unit Test for #2747 Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com> * Updated Unit Test Formatting for #2747 Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com> * Updated Unit Test Formatting for #2747 Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com> * Updated Unit Test HTML and formatting for #2747 Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com> * Bump Version for 2747 Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com> * Bump Version for 2747 Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com> --------- Signed-off-by: DCoomer <deshuncoomer@gmail.com> Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com>
DCoomer
added a commit
to DCoomer/taiko
that referenced
this pull request
Mar 4, 2026
Updated Unit Test Formatting for getgauge#2747 Signed-off-by: DCoomer <20802896+DCoomer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a Relative Selector is passed in as the third argument inside of click(), it doesn't actually make it down to waitAndGetActionableElement.
We found that
await click(element, options, within(withinElement))doesn't search in the "within" element with the Biome Migration changesSigned-off-by: DCoomer deshuncoomer@gmail.com