Set connectedToRemoteBrowser to false for non remote browser#2750
Set connectedToRemoteBrowser to false for non remote browser#2750zabil merged 4 commits intogetgauge:masterfrom
Conversation
Signed-off-by: Roshan Pradeepam <roshan.pradeepam@omnicell.com>
Signed-off-by: Roshan Pradeepam <roshan.pradeepam@omnicell.com>
|
@rpradeepam can you revert formatting changes so that the unit tests can run? |
Signed-off-by: Roshan Pradeepam <roshan.pradeepam@omnicell.com>
Done |
|
Tests are failing for me on local even without my changes. Not sure if it is because I am on a mac. |
Signed-off-by: Roshan Pradeepam <roshan.pradeepam@omnicell.com>
|
Locked the Ubuntu version used in Github Action to 22.04. Deploys till a few days back were using this version. https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md |
|
@zabil all the checks have passed, but the reporting is showing as pending due the the change in check name. Do I need to do something here? |
|
I think the pending tests are because of the ubuntu version pinning. Changed repository settings to reflect the status. Thanks for fixing the tests! |
|
@rpradeepam Thank you for contributing to taiko. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
Fixes #2749
If we open a local browser after opening and closing a remote browser, the closeBrowser step hangs.
The
connectedToRemoteBrowserproperty was not being reset after connecting to a remote browser.