[WIP] Looker integration#87
Merged
Merged
Conversation
Piotr Pękala (p-pekala)
requested changes
Sep 22, 2022
| "--docker-args", type=str, required=False, help="Args required to build project in json format" | ||
| ) | ||
| @click.option( | ||
| "--bi-build", |
Collaborator
There was a problem hiding this comment.
I'm thinking about turning it on and off from bi.yml instead. Maybe both could be used. We would like to control it without changes in CICD process :)
| help="Whether to push to BI", | ||
| ) | ||
| @click.option( | ||
| "--key-path", |
Collaborator
There was a problem hiding this comment.
let's name it --bi-git-key-path maybe
| "fsspec", | ||
| "packaging>=20.4,<21.0", | ||
| "colorama==0.4.4", | ||
| "dbt2looker==0.10.0", |
Collaborator
There was a problem hiding this comment.
let's put it in "looker" target. Not everyone wants to install it.
| ): | ||
| with self.assertRaises(DependencyNotInstalledError): | ||
| DeployCommand("base", False, self.storage_uri, self.provider_args, True).deploy() | ||
| DeployCommand("base", False, self.storage_uri, self.provider_args, True, False, None).deploy() |
Collaborator
There was a problem hiding this comment.
If there are 2 parameters needed I would introduce separate objects for example bi_parameters and sent it instead the one you added (open-close principle).
Collaborator
Author
There was a problem hiding this comment.
bi configs moved to bi.yml, no longer needed more than one param for bi
…th option instead of key-path
…lags to bi.yml instead of call option
Piotr Pękala (p-pekala)
approved these changes
Sep 27, 2022
…y directory because of dbt2looker hardcoded paths
Piotr Pękala (p-pekala)
approved these changes
Oct 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looker integrationResolves
<issue nr here>Keep in mind: