ci(release): stop persisting credentials in the pin-refs checkout - #296
Merged
Conversation
The pin-refs job was the last checkout in the repo without persist-credentials: false — the app token landed in .git/config and survived for the rest of the job, which the incoming checkoutMustNotPersistCredentials control (ISSUE-307, PR #293) rightly flags in our own self-scan (94.7% < 100% threshold). Supply the token at push time through an env-based credential helper instead, the same pattern the homebrew job already uses: .git/config only stores the helper script, never the token. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
thomasboni
requested review from
Joseph94m,
Totara-thib and
coconux3
as code owners
July 3, 2026 16:30
PR SummaryLow Risk Overview The Reviewed by Cursor Bugbot for commit fe9bb7f. Bugbot is set up for automated code reviews on this repo. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The self-scan on #293 fails (94.7% < 100% threshold): the new
checkoutMustNotPersistCredentialscontrol (ISSUE-307) flags thepin-refsjob inrelease.yml— the only checkout in the repo withoutpersist-credentials: false. The GitHub App token was persisted into.git/configand survived for the rest of the job.What
persist-credentials: falseto thepin-refscheckout (and drop the now-unneededtoken:input — the repo is public, fetch needs no auth).homebrewjob already uses:.git/configonly ever stores the literal helper script, never the token, so no credential outlives the step.Verification
Built Plumber from #293's head and ran the self-scan against this branch with the control enabled:
Merging this first unblocks #293's Plumber gate.
🤖 Generated with Claude Code