fix(up): Cleaning up 'up' local runtime logic#271
Merged
IanWoodard merged 1 commit intomainfrom May 2, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
+ Coverage 94.67% 94.72% +0.04%
==========================================
Files 26 27 +1
Lines 2141 2217 +76
==========================================
+ Hits 2027 2100 +73
- Misses 114 117 +3 ☔ View full report in Codecov by Sentry. |
hubertdeng123
approved these changes
May 2, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
devservices upwill always print outStarting dependencies with local runtimes...(unless the user passes in the exclude_local flag), even if there are no dependencies with local runtimes. This was a quick and easy fix, and while I was in the area, I added some tests to ensure we validate when this message is printed as well cleaned up the surrounding logic.