Skip to content

feat(toggle): Updating toggling active dependency to be consistent#273

Merged
IanWoodard merged 1 commit intomainfrom
ianwoodard/di-759-update-toggling-to-local-runtimes-to-be-consistent-with
May 5, 2025
Merged

feat(toggle): Updating toggling active dependency to be consistent#273
IanWoodard merged 1 commit intomainfrom
ianwoodard/di-759-update-toggling-to-local-runtimes-to-be-consistent-with

Conversation

@IanWoodard
Copy link
Copy Markdown
Contributor

Updating toggling active dependencies to be consistent with the behavior of bringing up a service with dependencies with local runtimes. When toggling a containerized dependency that is active, it should be brought down and brought back up again locally, similar to how the up command works.

@IanWoodard IanWoodard requested a review from hubertdeng123 May 5, 2025 17:04
@codecov
Copy link
Copy Markdown

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.72%. Comparing base (e2c884b) to head (000b345).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files          27       27           
  Lines        2218     2220    +2     
=======================================
+ Hits         2101     2103    +2     
  Misses        117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanWoodard IanWoodard merged commit 4663e36 into main May 5, 2025
14 checks passed
@IanWoodard IanWoodard deleted the ianwoodard/di-759-update-toggling-to-local-runtimes-to-be-consistent-with branch May 5, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants