Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 94.86% 94.99% +0.13%
==========================================
Files 27 27
Lines 2238 2299 +61
==========================================
+ Hits 2123 2184 +61
Misses 115 115 ☔ View full report in Codecov by Sentry. |
hubertdeng123
approved these changes
May 28, 2025
Member
hubertdeng123
left a comment
hubertdeng123
left a comment
There was a problem hiding this comment.
Discussed offline, will add more custom spans in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding more context via spans and Sentry context. This will enable us to better track the performance of specific parts of the up command as well as better understand usage of the toggle command by tracking what dependencies are set to local runtimes when using up.
I broke off
_install_service_dependenciesas I felt it was more readable that way, especially since it would have been setting a variable in an even more nested context which would be easy to miss. I opted not to break more things off in the interest of keeping this PR on track.I did my best to add as much context as seemed reasonable without overdoing it. If I missed anything crucial or added unnecessary context, let me know.