Skip to content

fix(up): Fixing local runtime dependency mode #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanWoodard merged 1 commit into from
May 28, 2025
Merged

fix(up): Fixing local runtime dependency mode #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions devservices/commands/up.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,8 @@ def up(args: Namespace, existing_status: Status | None = None) -> None:
up(
Namespace(
service_name=local_runtime_dependency_name,
mode=mode,
exclude_local=True,
mode="default", # We intentionally don't use the mode from the parent command here
exclude_local=True, # TODO: This should be False (or maybe whatever the parent command is set to)
),
status,
)
Expand Down
20 changes: 10 additions & 10 deletions tests/commands/test_up.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1495,7 +1495,10 @@ def test_up_dependency_set_to_local(
},
},
},
"modes": {"default": ["redis", "local-runtime-service"]},
"modes": {
"default": ["redis", "local-runtime-service"],
"other": ["redis", "local-runtime-service"],
},
},
}
other_service_path = tmp_path / "code" / "other-service"
Expand All @@ -1507,7 +1510,7 @@ def test_up_dependency_set_to_local(
state.update_service_runtime("local-runtime-service", ServiceRuntime.LOCAL)

args = Namespace(
service_name=None, debug=False, mode="default", exclude_local=exclude_local
service_name=None, debug=False, mode="other", exclude_local=exclude_local
)

with (
Expand Down Expand Up @@ -1695,18 +1698,15 @@ def test_up_dependency_set_to_local(
if exclude_local:
mock_update_service_entry.assert_has_calls(
[
mock.call(
"other-service", "default", StateTables.STARTING_SERVICES
),
mock.call("other-service", "default", StateTables.STARTED_SERVICES),
mock.call("other-service", "other", StateTables.STARTING_SERVICES),
mock.call("other-service", "other", StateTables.STARTED_SERVICES),
]
)
else:
# Even though other-service is being brought up in mode "other", the local-runtime-service should be started in mode "default"
mock_update_service_entry.assert_has_calls(
[
mock.call(
"other-service", "default", StateTables.STARTING_SERVICES
),
mock.call("other-service", "other", StateTables.STARTING_SERVICES),
mock.call(
"local-runtime-service",
"default",
Expand All @@ -1715,7 +1715,7 @@ def test_up_dependency_set_to_local(
mock.call(
"local-runtime-service", "default", StateTables.STARTED_SERVICES
),
mock.call("other-service", "default", StateTables.STARTED_SERVICES),
mock.call("other-service", "other", StateTables.STARTED_SERVICES),
]
)

Expand Down
Loading