fix(up): devservices up will not restart supervisor if it is already running#284
Merged
hubertdeng123 merged 3 commits intomainfrom Jun 3, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 95.04% 95.13% +0.09%
==========================================
Files 27 28 +1
Lines 2359 2468 +109
==========================================
+ Hits 2242 2348 +106
- Misses 117 120 +3 ☔ View full report in Codecov by Sentry. |
IanWoodard
approved these changes
Jun 3, 2025
Contributor
IanWoodard
left a comment
IanWoodard
left a comment
There was a problem hiding this comment.
Left a few comments, but otherwise it looks good to go
Comment on lines
+191
to
+196
| subprocess.run( | ||
| ["supervisorctl", "-c", self.config_file_path, "update"], | ||
| check=True, | ||
| stdout=subprocess.DEVNULL, | ||
| stderr=subprocess.DEVNULL, | ||
| ) |
Contributor
There was a problem hiding this comment.
Shouldn't we also catch a subprocess error below now?
tests/utils/test_supervisor.py
Outdated
| stdout=subprocess.DEVNULL, | ||
| stderr=subprocess.DEVNULL, | ||
| ) | ||
| assert mock_subprocess_run.call_count == 1 |
Contributor
There was a problem hiding this comment.
why not assertCalledOnceWith?
Member
Author
There was a problem hiding this comment.
sure, either way not a big deal
hubertdeng123
deleted the
hubertdeng123/reload-config-if-supervisor-running
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it so that config changes are picked up on
devservices upinvocations. Edited or new programs will not be automatically be brought up. This means that if a config change goes in for a program that is currently running, the mode with the program must be brought up again. This behavior seems fine for now, and we can add on functionality later on to ensure the same programs running before are brought up again but seems lower priority