chore(config): Consolidate programs.conf file into config.yml#285
Merged
hubertdeng123 merged 6 commits intomainfrom Jun 17, 2025
Merged
chore(config): Consolidate programs.conf file into config.yml#285hubertdeng123 merged 6 commits intomainfrom
hubertdeng123 merged 6 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
- Coverage 95.61% 95.19% -0.42%
==========================================
Files 28 28
Lines 2597 2644 +47
==========================================
+ Hits 2483 2517 +34
- Misses 114 127 +13 ☔ View full report in Codecov by Sentry. |
IanWoodard
approved these changes
Jun 14, 2025
|
|
||
| programs_data: ProgramData = config.get("x-programs", {}) | ||
|
|
||
| self.has_programs = len(programs_data.keys()) > 0 |
Contributor
There was a problem hiding this comment.
Nit: would this work better as a method so it can check this data in realtime? I realize we may never add/remove programs after initialization in this case, but it seems more intuitive to treat it as if we could.
Member
Author
There was a problem hiding this comment.
Good point, but don't see a scenario where this would be very useful right now, so keeping it as is for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves previous programs.conf file definitions to config.yml. It allows for us to abstract default settings away from the user while keeping the config file more simple
Example
x-programsblock in config.yml: