Skip to content

feat(up/down): Multithread bringing up/down supervisor programs #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hubertdeng123 merged 3 commits into from
Jun 10, 2025
Merged

feat(up/down): Multithread bringing up/down supervisor programs #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3020ab
multithread bringing up supervisor programs
hubertdeng123 Jun 6, 2025
d9ec722
also multithread bringing down processes
hubertdeng123 Jun 9, 2025
8070657
add back stopping supervisor daemon
hubertdeng123 Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions devservices/commands/down.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,14 @@ def _bring_down_dependency(
return run_cmd(cmd.full_command, current_env)


def _stop_supervisor_program(
manager: SupervisorManager, program: str, status: Status
) -> None:
"""Stop a single supervisor program."""
status.info(f"Stopping {program}")
manager.stop_process(program)


def bring_down_supervisor_programs(
supervisor_programs: list[str], service: Service, status: Status
) -> None:
Expand All @@ -318,9 +326,13 @@ def bring_down_supervisor_programs(
service_name=service.name,
)

for program in supervisor_programs:
status.info(f"Stopping {program}")
manager.stop_process(program)
with concurrent.futures.ThreadPoolExecutor() as executor:
futures = [
executor.submit(_stop_supervisor_program, manager, program, status)
for program in supervisor_programs
]
for future in concurrent.futures.as_completed(futures):
_ = future.result()

status.info("Stopping supervisor daemon")
manager.stop_supervisor_daemon()
18 changes: 15 additions & 3 deletions devservices/commands/up.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,14 @@ def bring_up_docker_compose_services(
exit(1)


def _start_supervisor_program(
manager: SupervisorManager, program: str, status: Status
) -> None:
"""Start a single supervisor program."""
status.info(f"Starting {program}")
manager.start_process(program)


def bring_up_supervisor_programs(
service: Service, supervisor_programs: list[str], status: Status
) -> None:
Expand All @@ -403,6 +411,10 @@ def bring_up_supervisor_programs(
status.info("Starting supervisor daemon")
manager.start_supervisor_daemon()

for program in supervisor_programs:
status.info(f"Starting {program}")
manager.start_process(program)
with concurrent.futures.ThreadPoolExecutor() as executor:
futures = [
executor.submit(_start_supervisor_program, manager, program, status)
for program in supervisor_programs
]
for future in concurrent.futures.as_completed(futures):
_ = future.result()
Loading