Merged
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: devservices/commands/down.py
|
hubertdeng123
commented
Oct 3, 2025
| integrations=[ArgvIntegration()], | ||
| integrations=[ | ||
| ArgvIntegration(), | ||
| LoggingIntegration(sentry_logs_level=logging.DEBUG), |
Member
Author
There was a problem hiding this comment.
sentry logs integrates directly with the logging library:
https://docs.sentry.io/platforms/python/logs/
Member
Author
There was a problem hiding this comment.
hmmmm, looks like I'll actually need to instrument the sentry sdk since debug logs only appear when the debug flag is passed in
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
==========================================
+ Coverage 95.21% 95.22% +0.01%
==========================================
Files 28 28
Lines 2652 2662 +10
==========================================
+ Hits 2525 2535 +10
Misses 127 127 ☔ View full report in Codecov by Sentry. |
joshuarli
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some basic logs, since we should dogfood our own product.
example logs: https://sentry.sentry.io/explore/logs/?guidedStep=3&logsFields=timestamp&logsFields=message&logsSortBys=-timestamp&project=4507946704961536&statsPeriod=30d