Skip to content

fix(validate-pr): Allow trusted bots to bypass validation #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephanie-anderson merged 2 commits into from
Mar 27, 2026
+18 −0
Merged

fix(validate-pr): Allow trusted bots to bypass validation #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c5a904
fix(validate-pr): Allow trusted bots and service accounts to bypass v…
stephanie-anderson Mar 27, 2026
ed9b530
fix: Also skip draft enforcement for allowed bots
stephanie-anderson Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions validate-pr/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ runs:
- name: Convert PR to draft
if: >-
steps.validate.outputs.was-closed != 'true'
&& steps.validate.outputs.skipped != 'true'
&& github.event.pull_request.draft == false
shell: bash
env:
Expand All @@ -47,6 +48,7 @@ runs:
- name: Label and comment on draft conversion
if: >-
steps.validate.outputs.was-closed != 'true'
&& steps.validate.outputs.skipped != 'true'
&& github.event.pull_request.draft == false
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
with:
Expand Down
16 changes: 16 additions & 0 deletions validate-pr/scripts/validate-pr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,22 @@ module.exports = async ({ github, context, core }) => {
const prAuthor = pullRequest.user.login;
const contributingUrl = `https://github.com/${repo.owner}/${repo.repo}/blob/${context.payload.repository.default_branch}/CONTRIBUTING.md`;

// --- Step 0: Skip allowed bots and service accounts ---
const ALLOWED_BOTS = [
'codecov-ai[bot]',
'dependabot[bot]',
'fix-it-felix-sentry[bot]',
'getsentry-bot',
'github-actions[bot]',
'javascript-sdk-gitflow[bot]',
'renovate[bot]',
];
if (ALLOWED_BOTS.includes(prAuthor)) {
core.info(`PR author ${prAuthor} is an allowed bot. Skipping.`);
core.setOutput('skipped', 'true');
return;
}

// --- Helper: check if a user has admin or maintain permission on a repo (cached) ---
const maintainerCache = new Map();
async function isMaintainer(owner, repoName, username) {
Expand Down
Loading