fix(github): Reauth malformed token refreshes#620
Merged
Conversation
Treat GitHub refresh-token rejection responses as user auth expiry even when the token endpoint returns HTTP 200. Keep unrelated OAuth errors operational so provider outages still surface as failures. Fixes JUNIOR-40 Co-Authored-By: GPT-5 Codex <codex@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub user-token refresh now treats refresh-token rejection responses as an auth-expired state even when the OAuth endpoint returns HTTP 200. This prevents sandbox egress from crashing on a successful HTTP response that contains no access token and lets the existing plugin auth pause flow ask the user to reconnect GitHub.
The change keeps non-expiry OAuth errors and malformed token responses after access-token parsing as operational failures, so provider outages or contract drift still surface for investigation. Focused GitHub plugin tests cover the 200 error-body cases and the operational-error boundary.
Fixes JUNIOR-40