feat(feedback): create a KafkaMessage type for user feedback#3467
Closed
aliu39 wants to merge 5 commits into
Closed
feat(feedback): create a KafkaMessage type for user feedback#3467aliu39 wants to merge 5 commits into
aliu39 wants to merge 5 commits into
Conversation
iker-barriocanal
left a comment
iker-barriocanal
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on the PR! Let us know in #discuss-ingest if there are any difficulties in making the PR work or tests pass.
| assert event["type"] == "feedback" | ||
|
|
||
|
|
||
| # /// If there is a UserReportV2 item, . The attachments should be kept in |
Contributor
There was a problem hiding this comment.
Is the commented code below valid? If not, let's remove it.
| 42, extra={"config": {"features": ["organizations:user-feedback-ingest"]}} | ||
| ) | ||
| # mini_sentry.set_global_config_option("feedback.ingest-topic.rollout-rate", 1.0) | ||
| # TODO: make and set a FF here |
Contributor
There was a problem hiding this comment.
Are the TODOs in this test part of the scope of this PR?
Member
Author
There was a problem hiding this comment.
Oh, that's weird, the changes to this file are all for another PR, not sure how I included them here. Will revert
Member
Author
|
Moving to #3403 to make merging this easier (good for code structuring and passing lint CI) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that feedback is moving to its own topic ingest-feedback-events (getsentry/sentry#66100), it's a good time to split it off from EventKafkaMessage.
Will be used by #3403. Attachments associated with a feedback are, and will continue to be, sent separately to the attachments topic. So this field is unnecessary.
Attachments are optional for the downstream ingest consumer, for all msgs read from ingest-events: https://github.com/getsentry/sentry/blob/40008bc7a981f8f577d506120a1da0ea0dc60cf0/src/sentry/ingest/consumer/processors.py#L68