Skip to content

fix(server): Allow multipart requests without trailing newline - #465

Merged
jan-auer merged 3 commits into
masterfrom
fix/form-data-boundary
Feb 11, 2020
Merged

fix(server): Allow multipart requests without trailing newline#465
jan-auer merged 3 commits into
masterfrom
fix/form-data-boundary

Conversation

@jan-auer

@jan-auer jan-auer commented Feb 11, 2020

Copy link
Copy Markdown
Member

This PR fixes multipart uploads without a trailing newline.

@jan-auer
jan-auer requested review from a team and untitaker February 11, 2020 14:48
@jan-auer jan-auer self-assigned this Feb 11, 2020
@jan-auer
jan-auer merged commit d2a05ef into master Feb 11, 2020
@jan-auer
jan-auer deleted the fix/form-data-boundary branch February 11, 2020 15:23
@constantinius constantinius mentioned this pull request Jul 9, 2026
Draft
constantinius added a commit that referenced this pull request Jul 16, 2026
@constantinius
feat(eap): Implement gen_ai attribute transformations
5b1564d 
Implement the two attribute transformations from sentry-conventions
PR #465: `gen_ai_request_messages_to_input_messages` and
`gen_ai_response_to_output_messages`.

These reshape attribute values beyond simple key renaming.
`gen_ai.request.messages` with `content` fields is converted to
`gen_ai.input.messages` with `parts` arrays. `gen_ai.response.text`
(plain string, JSON string array, or objects with content) and
`gen_ai.response.tool_calls` are combined into a single
`gen_ai.output.messages` assistant message with typed parts.

The transformation is generic over `AttributesLike` so it works on both
`Attributes` (SpanV2) and `SpanData` (SpanV1) without duplication. It
runs inside both `normalize_ai` (EAP pipeline) and `enrich_ai_span_data`
(transaction/legacy pipeline).

Attributes with the new `"transform"` deprecation status produce
`WriteBehavior::CurrentName` so `normalize_attribute_names` leaves them
alone — the dedicated transformation code handles the full
move-and-reshape. Deprecated keys are always cleaned up, even when the
canonical key already exists or the value cannot be parsed.

Contributes to TET-2587
constantinius added a commit that referenced this pull request Jul 16, 2026
@constantinius
feat(eap): Implement gen_ai attribute transformations
8f8a074 
Implement the two attribute transformations from sentry-conventions
PR #465: `gen_ai_request_messages_to_input_messages` and
`gen_ai_response_to_output_messages`.

These reshape attribute values beyond simple key renaming.
`gen_ai.request.messages` with `content` fields is converted to
`gen_ai.input.messages` with `parts` arrays. `gen_ai.response.text`
(plain string, JSON string array, or objects with content) and
`gen_ai.response.tool_calls` are combined into a single
`gen_ai.output.messages` assistant message with typed parts.

The transformation is generic over `AttributesLike` so it works on both
`Attributes` (SpanV2) and `SpanData` (SpanV1) without duplication. It
runs inside both `normalize_ai` (EAP pipeline) and `enrich_ai_span_data`
(transaction/legacy pipeline).

Attributes with the new `"transform"` deprecation status produce
`WriteBehavior::CurrentName` so `normalize_attribute_names` leaves them
alone — the dedicated transformation code handles the full
move-and-reshape. Deprecated keys are always cleaned up, even when the
canonical key already exists or the value cannot be parsed.

Contributes to TET-2587
constantinius added a commit that referenced this pull request Aug 3, 2026
@constantinius
fix: point sentry-conventions submodule to merged PR #465 commit
ad98c57 
The previous ref was a local cherry-pick that doesn't exist on the
remote. Use the actual merged commit on origin/main instead.
constantinius added a commit that referenced this pull request Aug 3, 2026
@constantinius
fix: point sentry-conventions submodule to merged PR #465 commit
063a813 
The previous ref was a local cherry-pick that doesn't exist on the
remote. Use the actual merged commit on origin/main instead.
constantinius added a commit that referenced this pull request Aug 3, 2026
@constantinius
chore(conventions): Bump sentry-conventions to include transform status
c961631 
Bump the sentry-conventions submodule to include PR #465 which adds the
"transform" deprecation status for gen_ai attributes.

Also adds the Transform variant to DeprecationStatus in the build script
(producing WriteBehavior::CurrentName) and updates deprecated constant
usages for the app vitals attributes that were renamed in the same
range.
constantinius added a commit that referenced this pull request Aug 3, 2026
@constantinius
chore(conventions): Bump sentry-conventions to include transform status
af19b19 
Bump the sentry-conventions submodule to include PR #465 which adds the
"transform" deprecation status for gen_ai attributes.

Also adds the Transform variant to DeprecationStatus in the build script
(producing WriteBehavior::CurrentName) and updates deprecated constant
usages for the app vitals attributes that were renamed in the same
range.
constantinius added a commit that referenced this pull request Aug 3, 2026
@constantinius
chore(conventions): Bump sentry-conventions to include transform status
e183ab4 
Bump the sentry-conventions submodule to include PR #465 which adds the
"transform" deprecation status for gen_ai attributes.

Also adds the Transform variant to DeprecationStatus in the build script
(producing WriteBehavior::CurrentName) and updates deprecated constant
usages for the app vitals attributes that were renamed in the same
range.
constantinius added a commit that referenced this pull request Aug 3, 2026
@constantinius
chore(conventions): Bump sentry-conventions to include transform status
82f35cf 
Bump the sentry-conventions submodule to include PR #465 which adds the
"transform" deprecation status for gen_ai attributes.

Also adds the Transform variant to DeprecationStatus in the build script
(producing WriteBehavior::CurrentName) and updates deprecated constant
usages for the app vitals attributes that were renamed in the same
range.
constantinius added a commit that referenced this pull request Aug 4, 2026
@constantinius
feat(eap): Implement gen_ai attribute transformations
c879cfb 
Implement the two attribute transformations from sentry-conventions
PR #465: `gen_ai_request_messages_to_input_messages` and
`gen_ai_response_to_output_messages`.

These reshape attribute values beyond simple key renaming.
`gen_ai.request.messages` with `content` fields is converted to
`gen_ai.input.messages` with `parts` arrays. `gen_ai.response.text`
(plain string, JSON string array, or objects with content) and
`gen_ai.response.tool_calls` are combined into a single
`gen_ai.output.messages` assistant message with typed parts.

The transformation is generic over `AttributesLike` so it works on both
`Attributes` (SpanV2) and `SpanData` (SpanV1) without duplication. It
runs inside both `normalize_ai` (EAP pipeline) and `enrich_ai_span_data`
(transaction/legacy pipeline).

Attributes with the new `"transform"` deprecation status produce
`WriteBehavior::CurrentName` so `normalize_attribute_names` leaves them
alone — the dedicated transformation code handles the full
move-and-reshape. Deprecated keys are always cleaned up, even when the
canonical key already exists or the value cannot be parsed.

Contributes to TET-2587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@untitaker untitaker untitaker approved these changes

Assignees

@jan-auer jan-auer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jan-auer @untitaker