ref(spans): Add additional tags to usage/count per root - #5511
Merged
Conversation
Dav1dde
force-pushed
the
dav1d/span-metrics-more-tags
branch
from
January 5, 2026 16:36
8293246 to
95f0330
Compare
Dav1dde
marked this pull request as ready for review
January 7, 2026 14:16
Dav1dde
force-pushed
the
dav1d/span-metrics-more-tags
branch
from
January 7, 2026 14:20
e83993a to
c47df01
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jjbayer
approved these changes
Jan 8, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: getsentry/sentry#105630
Refs: INGEST-689
Adds
has_transactionto all spans which still have a transaction which is ingested and therefor also have transaction metrics. This will be later the indicator used in consumers to not double account for transactions.Adds
is_segmentto usage and count per root metrics used for dynamic sampling calculations.