fix(spans): Mark root spans as segments in OTel conversion - #5532
Merged
Conversation
Previously, the is_segment flag was only set when is_remote was true. However, root spans should also be marked as segments. This fix adds a check for empty parent_span_id to correctly identify root spans as segments. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
mjq
changed the title
mjq
marked this pull request as ready for review
January 13, 2026 17:56
Dav1dde
approved these changes
Jan 13, 2026
| // A remote span is a segment span, but not every segment span is remote: | ||
| // A span is also a segment if it has no parent span (i.e., it's a root span). | ||
| let is_root_span = parent_span_id.value().is_none(); | ||
| let is_segment = match is_remote { |
Member
There was a problem hiding this comment.
Could simplify the match to is_root_span || is_remote.unwrap_or(false)
Member
Author
Member
There was a problem hiding this comment.
Oh I was thinking to keep the match just instead match on true/false, but alternatively you can also do (is_root_span || is_remote.unwrap_or(false)).then_some(true) if you're feeling fancy.
Co-authored-by: David Herberth <david.herberth@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the is_segment flag was only set when is_remote was true. However, root spans should also be marked as segments. This fix adds a check for empty parent_span_id to correctly identify root spans as segments.